Create hotfix to avoid parsing of " in JSON strings#2345
Merged
christianlupus merged 2 commits intomasterfrom May 31, 2024
Merged
Create hotfix to avoid parsing of " in JSON strings#2345christianlupus merged 2 commits intomasterfrom
christianlupus merged 2 commits intomasterfrom
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Test Results 12 files 584 suites 1m 32s ⏱️ Results for commit d3af5ea. |
Collaborator
Author
|
/approve |
nextcloud-cookbook-bot
approved these changes
May 31, 2024
Collaborator
nextcloud-cookbook-bot
left a comment
nextcloud-cookbook-bot
left a comment
There was a problem hiding this comment.
Automatically approved by GitHub action on behalf of /approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
This is just a hot fix for #1077 hoping not to break many things.
Concerns/issues
As already mentioned in the issue, the real solution would be to fix the parser (#1675 #1110).
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.